On 06/15/2009 06:20 PM, Anthony Liguori wrote:
Avi Kivity wrote:
I would prefer explicit names (pci_addr, lun, etc.) but would be okay
with generic names too.
I think having a generic address has a lot of value in terms of code
implementation. Otherwise, the valid options for -drive become
context-sensitive which is going to be annoying and error-prone. Some
sanity could be added by using addressing prefixes like
addr=pci:00:01.0 or addr=scsi:0.3 but I'll leave that up to whoever
takes this on.
The code problems are easily solved by adding another level of
indirection. User confusion problems are only aggravated by additional
abstraction, though ("what do I put in addr=, here?").
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
