Re: [PATCH 1/2][KVM] nVMX x86: Add a check for reserved bits [11:0] of PML address

[Jim Mattson <jmattson@xxxxxxxxxx>]

On Wed, Sep 26, 2018 at 2:15 PM, Krish Sadhukhan
<krish.sadhukhan@xxxxxxxxxx> wrote:

>      if (nested_cpu_has_pml() && (!nested_cpu_has_ept(vmcs12) ||
>             !page_address_valid(vcpu, vmcs12->pml_address))
>     .            return -EINVAL;

Perhaps this would be more readable in the style of
nested_vmx_check_msr_bitmap_controls:

if (!nested_cpu_has_pml(vmcs12))
        return 0;

if (!nested_cpu_has_ept(vmcs12) ||
    !page_address_valid(vcpu, vmcs12->pml_address))
        return -EINVAL;

return 0;