Re: [PATCH 1/2] virtio/s390: avoid race on vcdev->config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/24/2018 02:55 PM, Cornelia Huck wrote:
> On Fri, 21 Sep 2018 17:47:47 -0400
> Farhan Ali <alifm@xxxxxxxxxxxxx> wrote:
> 
>> On 09/21/2018 09:28 AM, Halil Pasic wrote:
> 
>>> Anyway I'm fine with swapping the old out and your new version in,
>>> if you prefer it that way.
>>>
>>> If you do, would you like to have a respin?
> 
> Just send me a respin with something that you find useful :) (maybe a
> mashup of our descriptions) (while at it, you could also add the
> cc:stable, which I agree make sense)
> 

Will do! I would like to go with.


"""
This normally does not cause problems, as these are usually infrequent
operations. However, for some devices writing to/reading from the config space
can be triggered through sysfs attributes. For these userspace can force the
race by increasing the frequency.
"""

>>>
>>> Regards,
>>> Halil
>>>   
>>
>> I had been looking into this code recently, and shouldn't vcdev->status 
>> (function get/set_status functions) also have a lock around it? Or is it 
>> not possible to have a race condition on vcdev->status?
> 
> I don't think so, as status is only a byte.
> 

Nod.

Thanks,
Halil




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux