> Subject: Re: [PATCH 1/3] nd: move nd_region to common header > > On Fri, Aug 31, 2018 at 6:31 AM Pankaj Gupta <pagupta@xxxxxxxxxx> wrote: > > > > This patch moves nd_region definition to common header > > include/linux/nd.h file. This is required for flush callback > > support for both virtio-pmem & pmem driver. > > > > Signed-off-by: Pankaj Gupta <pagupta@xxxxxxxxxx> > > --- > > drivers/nvdimm/nd.h | 39 --------------------------------------- > > include/linux/nd.h | 40 ++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 40 insertions(+), 39 deletions(-) > > No, we need to find a way to do this without dumping all of these > internal details to a public / global header. This is required when virtio_pmem driver accesses fields of nd_region struct. Instead if we pass device pointer in place of nd_region, we don't need to put this in global header. Thoughts? e.g virtio_pmem_flush(struct device *dev) Thanks, Pankaj
