Re: [PATCH v2 13/18] KVM: nVMX: do not skip VMEnter instruction that succeeds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 28, 2018 at 9:04 AM, Sean Christopherson
<sean.j.christopherson@xxxxxxxxx> wrote:
> A successful VMEnter is essentially a fancy indirect branch that
> pulls the target RIP from the VMCS.  Skipping the instruction is
> unnecessary (RIP will get overwritten by the VMExit handler) and
> is problematic because it can incorrectly suppress a #DB due to
> EFLAGS.TF when a VMFail is detected by hardware (happens after we
> skip the instruction).
>
> Now that vmx_nested_run() is not prematurely skipping the instr,
> use the full kvm_skip_emulated_instruction() in the VMFail path
> of nested_vmx_vmexit().  We also need to explicitly update the
> GUEST_INTERRUPTIBILITY_INFO when loading vmcs12 host state.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux