On Wed, Sep 19, 2018 at 02:22:09PM -0700, Jim Mattson wrote: > On Tue, Aug 28, 2018 at 9:04 AM, Sean Christopherson > <sean.j.christopherson@xxxxxxxxx> wrote: > > Reset the vm_{entry,exit}_controls_shadow variables as well as the > > segment cache on consistency check VMExit. The shadow values in > > particular can lead to missed updates due to stale shadows. > > I feel like this should go into vmx_switch_vmcs() instead. Every time > we switch vmcs, for whatever reason, the shadows are going to be > stale. That would make a lot more sense.