On Fri, Sep 14, 2018 at 02:14:49AM +0300, Liran Alon wrote:
>
>
> > On 13 Sep 2018, at 16:59, Sean Christopherson <sean.j.christopherson@xxxxxxxxx> wrote:
> >
> > After reading through the existing code a bit more, I think all calls
> > to vmx_mpx_supported() should be replaced with kvm_mpx_supported().
> > The KVM version returns true iff MPX is enabled in the host, and was
> > added by commit a87036add092 ("KVM: x86: disable MPX if host did not
> > enable MPX XSAVE features").
>
> I agree.
> This should also include the call kvm_x86_ops->mpx_supported() inside kvm_init_msr_list().
> Do you think it is preferable to do your suggested patch before or after the patch discussed in this email thread?
Probably before? Only because it seems weird to knowingly do the
wrong thing.
