On Mon, 2018-09-10 at 13:44 +0200, Paolo Bonzini wrote: > On 06/09/2018 17:23, Sean Christopherson wrote: > > > > Has anyone had a chance to look at any of these patches, especially > > patches 1-16? I'm fairly indifferent with regard to getting the early > > consistency check stuff in mainline, but I'd like to get the bug fixes > > and refactoring upstreamed sooner rather than later. I can attempt to > > break this into multiple series if bundling everything together is > > unpalatable. > > > Back from vacation, I'll look at this series this week. I find it a > very useful tool, and actually I'm thinking of adding a Kconfig symbol > to enable early_consistency_checks by default. Distros may want to > enable it in their debug kernels. Thanks! I need to tweak patch 17/18[1], I'll wait to do that until you've had a chance to review the rest of the series. [1] Using GUEST_RIP to force the consistency check VMExit doesn't work on 32-bit since we can't write bits 63:32 (thankfully 0-Day caught this issue). GUEST_RFLAGS is a good (and maybe better) alternative. I'll also enhance the changelog to explain the reasoning behind using GUEST_RFLAGS.
