RE: [PATCH v12 00/12] Intel Processor Trace virtualization enabling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > -----Original Message-----
> > From: Kang, Luwei
> > Sent: Thursday, July 26, 2018 5:43 PM
> > To: kvm@xxxxxxxxxxxxxxx
> > Cc: x86@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx;
> > hpa@xxxxxxxxx; thomas.lendacky@xxxxxxx; bp@xxxxxxx;
> > konrad.wilk@xxxxxxxxxx; mattst88@xxxxxxxxx;
> > Janakarajan.Natarajan@xxxxxxx; dwmw@xxxxxxxxxxxx;
> > alexander.shishkin@xxxxxxxxxxxxxxx; songliubraving@xxxxxx;
> > kstewart@xxxxxxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx;
> > peterz@xxxxxxxxxxxxx; pbonzini@xxxxxxxxxx; rkrcmar@xxxxxxxxxx;
> > david@xxxxxxxxxx; bsd@xxxxxxxxxx; marcorr@xxxxxxxxxx; joro@xxxxxxxxxx;
> > Kang, Luwei <luwei.kang@xxxxxxxxx>
> > Subject: [PATCH v12 00/12] Intel Processor Trace virtualization
> > enabling
> >
> > Hi All,
> >
> > Here is a patch-series which adding Processor Trace enabling in KVM guest. You can get It's software developer manuals from:
> > https://software.intel.com/sites/default/files/managed/c5/15/architect
> > ure-instruction-set-extensions-programming-reference.pdf
> > In Chapter 4 INTEL PROCESSOR TRACE: VMX IMPROVEMENTS.
> >
> > Introduction:
> > Intel Processor Trace (Intel PT) is an extension of Intel Architecture
> > that captures information about software execution using dedicated
> > hardware facilities that cause only minimal performance perturbation to the software being traced. Details on the Intel PT
> infrastructure and trace capabilities can be found in the Intel 64 and IA-32 Architectures Software Developer’s Manual, Volume 3C.
> >
> > The suite of architecture changes serve to simplify the process of
> > virtualizing Intel PT for use by a guest software. There are two primary elements to this new architecture support for VMX
> support improvements made for Intel PT.
> > 1. Addition of a new guest IA32_RTIT_CTL value field to the VMCS.
> >   — This serves to speed and simplify the process of disabling trace on VM exit, and restoring it on VM entry.
> > 2. Enabling use of EPT to redirect PT output.
> >   — This enables the VMM to elect to virtualize the PT output buffer
> > using EPT. In this mode, the CPU will treat PT output addresses as
> > Guest Physical Addresses (GPAs) and translate them using EPT. This means that Intel PT output reads (of the ToPA table) and
> writes (of trace output) can cause EPT violations, and other output events.
> >
> > Processor Trace virtualization can be work in one of 2 possible modes by set new option "pt_mode". Default value is system
> mode.
> >  a. system-wide: trace both host/guest and output to host buffer;  b.
> > host-guest: trace host/guest simultaneous and output to their respective buffer.
> >
> > >From V11:
> >  - In patch 3, arguments caps vs. cap is not good. Spell second one
> > out. -- Thomas Gleixner
> >
> > >From V10: (This version don't have code change)
> >  - move the patch 5 in version 9 to patch 3 (reorder patch 5) --
> > Alexander Shishkin
> >  - refind the patch description of patch 5 (add new capability for
> > Intel PT) -- Alexander Shishkin
> >  - CC all the maintainers, reviewers and submitters in each patch of
> > this patch set -- Alexander Shishkin
> >
> > >From V9:
> >  - remove redundant initialize for "ctl_bitmask" in patch 9;
> >  - do some changes for patch's description.
> >
> > >From V8:
> >  - move macro definition MSR_IA32_RTIT_ADDR_RANGE from msr-index.h to
> > intel_pt.h;
> >  - initialize the RTIT_CTL bitmask to ~0ULL.
> >
> > >From V7:
> >  - remove host only mode since it can be emulated by perf code;
> >  - merge patch 8 and 9 to make code and data in the same patch;
> >  - rename __pt_cap_get() to pt_cap_decode();
> >  - other minor change.
> >
> > >From V6:
> >  - split pathes 1~2 to four separate patches (these patches do 2 things) and add more descriptions.
> >
> > >From V5:
> >  - rename the function from pt_cap_get_ex() to __pt_cap_get();
> >  - replace the most of function from vmx_pt_supported() to "pt_mode == PT_MODE_HOST_GUEST"(or !=).
> >
> > >From V4:
> >  - add data check when setting the value of MSR_IA32_RTIT_CTL;
> >  - Invoke new interface to set the intercept of MSRs read/write after "MSR bitmap per-vcpu" patches.
> >
> > >From V3:
> >  - change default mode to SYSTEM mode;
> >  - add a new patch to move PT out of scattered features;
> >  - add a new fucntion kvm_get_pt_addr_cnt() to get the number of
> > address ranges;
> >  - add a new function vmx_set_rtit_ctl() to set the value of guest RTIT_CTL, GUEST_IA32_RTIT_CTL and MSRs intercept.
> >
> > >From v2:
> >  - replace *_PT_SUPPRESS_PIP to *_PT_CONCEAL_PIP;
> >  - clean SECONDARY_EXEC_PT_USE_GPA, VM_EXIT_CLEAR_IA32_RTIT_CTL and VM_ENTRY_LOAD_IA32_RTIT_CTL in SYSTEM
> mode.
> > These bits must be all set or all clean;
> >  - move processor tracing out of scattered features;
> >  - add a new function to enable/disable intercept MSRs read/write;
> >  - add all Intel PT MSRs read/write and disable intercept when PT is
> > enabled in guest;
> >  - disable Intel PT and enable intercept MSRs when L1 guest VMXON;
> >  - performance optimization.
> >    In Host only mode. we just need to save host RTIT_CTL before vm-entry and restore host RTIT_CTL after vm-exit;
> >    In HOST_GUEST mode. we need to save and restore all MSRs only when PT has enabled in guest.
> >  - use XSAVES/XRESTORES implement context switch.
> >    Haven't implementation in this version and still in debuging. will make a separate patch work on this.
> >
> > >From v1:
> >  - remove guest-only mode because guest-only mode can be covered by
> > host-guest mode;
> >  - always set "use GPA for processor tracing" in secondary execution
> > control if it can be;
> >  - trap RTIT_CTL read/write. Forbid write this msr when VMXON in L1 hypervisor.
> >
> > Chao Peng (7):
> >   perf/x86/intel/pt: Move Intel-PT MSRs bit definitions to a public
> >     header
> >   perf/x86/intel/pt: Change pt_cap_get() to a public function
> >   KVM: x86: Add Intel Processor Trace virtualization mode
> >   KVM: x86: Add Intel Processor Trace cpuid emulation
> >   KVM: x86: Add Intel Processor Trace context switch for each vcpu
> >   KVM: x86: Implement Intel Processor Trace MSRs read/write emulation
> >   KVM: x86: Set intercept for Intel PT MSRs read/write
> >
> > Luwei Kang (5):
> >   perf/x86/intel/pt: Introduce a new function to get capability of Intel
> >     PT
> >   perf/x86/intel/pt: Add new bit definitions for Intel PT MSRs
> >   perf/x86/intel/pt: add new capability for Intel PT
> >   KVM: x86: Introduce a function to initialize the PT configuration
> >   KVM: x86: Disable Intel Processor Trace when VMXON in L1 guest
> >
> >  arch/x86/events/intel/pt.c       |  14 +-
> >  arch/x86/events/intel/pt.h       |  58 -----
> >  arch/x86/include/asm/intel_pt.h  |  39 ++++
> >  arch/x86/include/asm/kvm_host.h  |   1 +
> >  arch/x86/include/asm/msr-index.h |  37 ++++
> >  arch/x86/include/asm/vmx.h       |   8 +
> >  arch/x86/kvm/cpuid.c             |  22 +-
> >  arch/x86/kvm/svm.c               |   6 +
> >  arch/x86/kvm/vmx.c               | 441 ++++++++++++++++++++++++++++++++++++++-
> >  arch/x86/kvm/x86.c               |  33 ++-
> >  10 files changed, 591 insertions(+), 68 deletions(-)
> >
> 
> Hi x86 people,
>     Patch 1~5 have some code changes in x86 native for Intel Processor Trace virtualization enabling in KVM guest.
>     Please, can you review this and hopefully provide a topic branch ?

Ping.

> 
> Thanks,
> Luwei Kang




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux