On 24.08.2018 14:03, Stefan Raspl wrote:
> A couple of patches, mostly dealing with handling of guests that are
> shut down while kvm_stat is running.
> However, was sadly pulled into the tedious Python3 area, so had to
> pick up some flotsam on the way :/
>
> Stefan Raspl (7):
> tools/kvm_stat: fix python3 issues
> tools/kvm_stat: fix handling of invalid paths in debugfs provider
> tools/kvm_stat: fix updates for dead guests
> tools/kvm_stat: don't reset stats when setting PID filter for debugfs
> tools/kvm_stat: handle guest removals more gracefully
> tools/kvm_stat: indicate dead guests as such
> tools/kvm_stat: re-animate display of dead guests
>
> tools/kvm/kvm_stat/kvm_stat | 59 +++++++++++++++++++++++++++++++++++++--------
> 1 file changed, 49 insertions(+), 10 deletions(-)
>
Any consideration so far...?
In the meantime, here's another one for a glitch I stumbled across:
Author: Stefan Raspl <stefan.raspl@xxxxxxxxxx>
tools/kvm_stat: cut down decimal places in update interval dialog
We currently display the default number of decimal places for floats in
_show_set_update_interval(), which is quite pointless. Cutting down to a
single decimal place.
Signed-off-by: Stefan Raspl <raspl@xxxxxxxxxxxxx>
diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index 439b8a27488d..195ba486640f 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -1325,7 +1325,7 @@ class Tui(object):
msg = ''
while True:
self.screen.erase()
- self.screen.addstr(0, 0, 'Set update interval (defaults to %fs).' %
+ self.screen.addstr(0, 0, 'Set update interval (defaults to %.1fs).' %
DELAY_DEFAULT, curses.A_BOLD)
self.screen.addstr(4, 0, msg)
self.screen.addstr(2, 0, 'Change delay from %.1fs to ' %
