On Mon, Aug 27, 2018 at 12:39:36PM -0700, Dave Hansen wrote: > On 08/27/2018 11:53 AM, Jarkko Sakkinen wrote: > > + /* Intel SGX features: level 0x00000012 */ > > + if (c->cpuid_level >= 0x00000012) { > > + cpuid(0x00000012, &eax, &ebx, &ecx, &edx); > > + > > + c->x86_capability[CPUID_12_EAX] = eax; > > + } > > I've given this specific bit of feedback at least once in the past. > These patches are not ordered properly. You introduce this in the next > patch: > > +#define SGX_CPUID 0x12 Yeah, my mistake probably when squashing fixups. /Jarkko