On 23/08/2018 18:01, Jinpu Wang wrote:
> Hi Paolo,
>
> I notice latest kvm-unit-test ()5586165785d3 ("nVMX x86: "virtualize
> APIC accesses" must be unset if "virtualize x2APIC" is set") no long
> builds:
> x86/vmx_tests.c:3772:13: error: redefinition of ‘test_apic_virtual_ctls’
> static void test_apic_virtual_ctls(void)
> ^~~~~~~~~~~~~~~~~~~~~~
> x86/vmx_tests.c:3622:13: note: previous definition of
> ‘test_apic_virtual_ctls’ was here
> static void test_apic_virtual_ctls(void)
> ^~~~~~~~~~~~~~~~~~~~~~
> x86/vmx_tests.c:3909:13: error: redefinition of ‘test_apic_ctls’
> static void test_apic_ctls(void)
> ^~~~~~~~~~~~~~
> x86/vmx_tests.c:3752:13: note: previous definition of ‘test_apic_ctls’ was here
> static void test_apic_ctls(void)
> ^~~~~~~~~~~~~~
> x86/vmx_tests.c:3752:13: error: ‘test_apic_ctls’ defined but not used
> [-Werror=unused-function]
>
> Looks we a 2 duplicated function from these 2 patches:
> da4eb157c8fc ("nVMX x86: APIC virtual controls must be unset if "Use
> TPR shadow" is unset")
> bc0eb3d959b6 ("nVMX x86: APIC virtual controls must be unset if "Use
> TPR shadow" is unset")
>
> Do we need both commits?
Oops. No, the same change was committed twice, but unfortunately git
didn't notice that.
Paolo
