On 21/08/2018 00:53, Wei Yang wrote: > On Mon, Aug 20, 2018 at 04:44:25PM -0400, Konrad Rzeszutek Wilk wrote: >> On Mon, Aug 20, 2018 at 08:23:29PM +0000, Wei Yang wrote: >>> On Mon, Aug 20, 2018 at 09:47:20AM -0400, Konrad Rzeszutek Wilk wrote: >>>> On Sun, Aug 19, 2018 at 08:17:45AM +0800, Wei Yang wrote: >>>>> update_memslots() is only called by __kvm_set_memory_region(), in which >>>>> change is calculated to indicate the following behavior. With this >>>> >>>> What is the 'following behavior' you mention? >>> >>> Ah, 'following behavior' means what need to do in update_memslots() to >>> used_slots. >>> >>> For example, if change equals KVM_MR_CREATE, it means update_memslots() >>> will add a new slot and used_slots need to increase by one. >>> >>> With this information, we don't need to do the calculation in >>> update_memslots() again, but just do an addition. >> >> Could you update the commit ot have this description please? >>> > > Sure. > > Per comments from Paolo in patch 2, only this one is necessary in next > spin, right? I don't know... Encoding the delta in bits 0-7 is not something I would really do unless it's super important for performance. Paolo
