On 14/08/2018 19:15, Junaid Shahid wrote: > access &= ACC_WRITE_MASK | ACC_USER_MASK; > - mask |= shadow_mmio_value | access | gfn << PAGE_SHIFT; > + mask |= shadow_mmio_value | shadow_nonpresent_or_rsvd_mask; > + mask |= access | gpa; > + mask |= (gpa & shadow_nonpresent_or_rsvd_mask) > + << shadow_nonpresent_or_rsvd_mask_len; Just a microscopic change here which is a little bit clearer in my opinion: + mask |= shadow_mmio_value | access; + mask |= gpa | shadow_nonpresent_or_rsvd_mask; + mask |= (gpa & shadow_nonpresent_or_rsvd_mask) + << shadow_nonpresent_or_rsvd_mask_len; Thanks, queued for 4.19-rc1. Paolo
