Re: [patch 2/5] KVM: MMU: make for_each_shadow_entry aware of largepages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marcelo Tosatti wrote:
@@ -1273,6 +1273,11 @@ static bool shadow_walk_okay(struct kvm_
 {
     if (iterator->level < PT_PAGE_TABLE_LEVEL)
         return false;
+
+    if (iterator->level == PT_PAGE_TABLE_LEVEL)
+        if (is_large_pte(*iterator->sptep))
+            return false;

s/==/>/?

Ah, it's actually fine.  But changing == to >= will make it 1GBpage-ready.

Humpf, better check level explicitly before interpreting bit 7, so lets skip this for 1GB pages.


Okay.  But I'm rewriting shadow_walk_* afterwards.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux