Re: [PATCH 08/11] KVM: vmx: move struct host_state usage to struct loaded_vmcs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 23/07/2018 21:32, Sean Christopherson wrote:
> + * vmcs_host_state tracks registers that are loaded from the VMCS on VMEXIT
> + * and whose values change infrequently, but are not consant.  I.e. this is
> + * used as a write-through cache of the corresponding VMCS fields.
> + */
> +struct vmcs_host_state {
> +	unsigned long cr3;	/* May not match real cr3 */
> +	unsigned long cr4;	/* May not match real cr4 */
> +

I'm removing these comments, since what they meant is "sometimes the
value is stale".  But your new comment is more precise.

(Also, s/consant/constant/).

Paolo



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux