On 07/31/2018 02:24 PM, Cornelia Huck wrote:
+static int vfio_ap_mdev_reset_queues(struct mdev_device *mdev, bool force) +{ + int ret; + int rc = 0; + unsigned long apid, apqi; + struct ap_matrix_mdev *matrix_mdev = mdev_get_drvdata(mdev); + + if (!matrix_mdev->activated) { + pr_err("%s: reset failed for mdev %s, not activated", + VFIO_AP_MODULE_NAME, matrix_mdev->name); + + return -EPERM; + }Hm... if we stick with the activation approach, what happens if we: - open the mdev - activate the matrix - deactivate the matrix
I guess this step will fail and the matrix remains activated. Have a look at vfio_ap_mdev_deactivate()
- release the mdev, triggering this function It seems we won't call PAPQ(ZAPQ) in that case -- is that how it is supposed to work?
So basically the device remains active until the mdev release is called if I'm correct. Halil
