> For integrity's sake, I must add the following: > > While I think this change would be technically correct (= the file > should not be advertised, after build, as executable), it now seems that > the patch would not help with the packaging issue. > > It appears that the RPM build infrastructure, at least in Fedora28+, > ignores the x file mode bits when it decides to color a file as "1" (= > 32-bit ELF). > > https://bugzilla.redhat.com/show_bug.cgi?id=1608852#c2 > > This behavior looks *entirely inconsistent* with how RPM building seems > to work in RHEL7, but that's the situation we got, apparently. > > I believe this finding makes the commit message *in part* dubious. > Therefore, personally I'd be fine if we dropped the patch (although I do > believe what it does is still correct, just not with the original > justification). >From a !packaging point of view, this is the right thing to do. These are binary blobs to be loaded into a guest VM, not executables. Thomas, maybe simply drop that part about packaging from the commit message. > > Thanks, > Laszlo > -- Thanks, David / dhildenb
