On Thu, 26 Jul 2018 17:43:45 +0200 Erik Skultety <eskultet@xxxxxxxxxx> wrote: > On Thu, Jul 26, 2018 at 05:30:07PM +0200, Cornelia Huck wrote: > > One thing I noticed is that we have seem to have an optional (?) > > vendor-driver created "aggregation" attribute (which always prints > > "true" in the Intel driver). Would it be better or worse for libvirt if > > it contained some kind of upper boundary or so? Additionally, would it > > Can you be more specific? Although, I wouldn't argue against data that conveys > some information, since I would treat the mere presence of the optional > attribute as a supported feature that we can expose. Therefore, additional > *structured* data which sets clear limits to a certain feature is only a plus > that we can expose to the users/management layer. My question is what would be easiest for libvirt: - "aggregation" attribute only present when driver supports aggregation (possibly containing max number of resources to be aggregated) - "aggregation" attribute always present; contains '1' if driver does not support aggregation and 'm' if driver can aggregate 'm' resources
