Re: [PATCH 06/11] KVM: nVMX: remove a misleading comment regarding vmcs02 fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 23, 2018 at 12:33 PM Sean Christopherson
<sean.j.christopherson@xxxxxxxxx> wrote:
>
> prepare_vmcs02() has an odd comment that says certain fields are
> "not in vmcs02".  AFAICT the intent of the comment is to document
> that various VMCS fields are not handled by prepare_vmcs02(),
> e.g. HOST_{FS,GS}_{BASE,SELECTOR}.  While technically true, the
> comment is misleading, e.g. it can lead the reader to think that
> KVM never writes those fields to vmcs02.
>
> Remove the comment altogether as the handling of FS and GS is
> not specific to nested VMX, and GUEST_PML_INDEX has been written
> by prepare_vmcs02() since commit "4e59516a12a6 (kvm: vmx: ensure
> VMCS is current while enabling PML)"
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@xxxxxxxxx>

Reviewed-by: Peter Shier <pshier@xxxxxxxxxx>
Tested-by: Peter Shier <pshier@xxxxxxxxxx>



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux