On Mon, Jul 23, 2018 at 01:54:10PM +0100, Marc Zyngier wrote: > On 23/07/18 10:44, Suzuki K Poulose wrote: > > On 07/22/2018 04:53 PM, Michael S. Tsirkin wrote: > >> On Wed, Jul 18, 2018 at 10:18:45AM +0100, Suzuki K Poulose wrote: > >>> Legacy PCI over virtio uses a 32bit PFN for the queue. If the > >>> queue pfn is too large to fit in 32bits, which we could hit on > >>> arm64 systems with 52bit physical addresses (even with 64K page > >>> size), we simply miss out a proper link to the other side of > >>> the queue. > >>> > >>> Add a check to validate the PFN, rather than silently breaking > >>> the devices. > >>> > >>> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx> > >>> Cc: Jason Wang <jasowang@xxxxxxxxxx> > >>> Cc: Marc Zyngier <marc.zyngier@xxxxxxx> > >>> Cc: Christoffer Dall <cdall@xxxxxxxxxx> > >>> Cc: Peter Maydel <peter.maydell@xxxxxxxxxx> > >>> Cc: Jean-Philippe Brucker <jean-philippe.brucker@xxxxxxx> > >>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx> > >> > >> Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > > > Michael, > > > > Thanks. > > > >> > >> I assume this will be merged through some other tree. > >> > > > > > > As such these two virtio patches do not have any code dependencies with > > the rest of the series. So, if you could pick this up it should be fine. > > Otherwise, may be Marc can push it with the rest of the series. > > > > Marc, > > > > Are you OK with that ? > > Given that these two patches completely independent, I think their > natural path should be the virtio tree. But if Michael doesn't want to > pick them, I'll do it as part of this series. > > Thanks, > > M. It's ok, I can pick them up. > -- > Jazz is not dead. It just smells funny...