On 07/20/2018 09:40 AM, Janosch Frank wrote:
Now we have 2 variables for skeys (use_skf and skey_enabled), shouldn't
we combine them into one struct? I feel it would be easier to understand
the code.
use_skf is the indication if we are allowed to use the storage key
facility for skey interpretation. vcpu->arch.skey_enabled is a direct
indication if we removed the ictls/kss on this vcpu.
Right, my point being if it made sense to have both the variables in one
in one struct. Regardless of that, I think the patch is an improvement
over the long if statement, so
Acked-by: Farhan Ali <alifm@xxxxxxxxxxxxx>
