On Mon, Jul 16, 2018 at 03:06:18PM +0200, Christoffer Dall wrote: > Instead of hardcoding the shifts and masks in the GICD_IIDR register > emulation, let's add the definition of these fields to the GIC header > files and use them. > > This will make things more obvious when we're going to bump the revision > in the IIDR when we'll make guest-visible changes to the implementation. > > Signed-off-by: Christoffer Dall <christoffer.dall@xxxxxxx> > --- > include/linux/irqchip/arm-gic-v3.h | 10 ++++++++++ > include/linux/irqchip/arm-gic.h | 10 ++++++++++ > virt/kvm/arm/vgic/vgic-mmio-v2.c | 3 ++- > virt/kvm/arm/vgic/vgic-mmio-v3.c | 3 ++- > 4 files changed, 24 insertions(+), 2 deletions(-) > Reviewed-by: Andrew Jones <drjones@xxxxxxxxxx>