On 19 July 2018 at 09:54, gengdongjiu <gengdongjiu@xxxxxxxxxx> wrote: > Hi peter, > Thanks for the review. > > On 2018/7/18 0:36, Peter Maydell wrote: >> How does this capability interact with the KVM_CAP_VCPU_EVENTS >> API in patch 1? Is it saying "you can specify the ESR via >> that API", or talking about something else? > > The user space will firstly check the KVM_CAP_VCPU_EVENTS through kvm_has_vcpu_events() to know whether KVM can support get/set vcpu events, > If KVM supports get/set vcpu events, it will check KVM_CAP_ARM_SET_SERROR_ESR to know whether can set guest SError ESR, as shown the user space code in [1]. OK, so this capability affects the behaviour of KVM_SET_VCPU_EVENTS. Can you make sure the documentation of KVM_SET_VCPU_EVENTS clearly explains what happens and the effect of whether this capability is present, please? People trying to understand the behaviour of that ioctl are not going to know that they need to look here as well. thanks -- PMM
