On 18/07/2018 13:54, Liran Alon wrote: > > On 18/07/18 14:33, Paolo Bonzini wrote: >> On 18/07/2018 13:15, Liran Alon wrote: >>>>> Most patches of series haven't got any reply yet (submitted 3 weeks >>>>> ago). >>>> I am queuing patches 1-13, thanks---and sorry for the delay in review. >>>> >>>> Paolo >>>> >>> Radim had some minor comments on some of these patches (such as renaming >>> a function). >>> I replied that I agree with him and will do them in v2 of the series >>> after all >>> patches of series will be reviewed. >>> >>> Do you plan to do these minor changes when applying or do you want to >>> queue these patches >>> only after I submit patches for v2 of this entire series? >>> (I of course prefer the first option ^_^). >> After the discussion with Jim, I wasn't really sure about the name >> anymore, and couldn't make a decision myself. It's probably >> nested_cpu_has* that should be renamed. >> >> The only other comment is "I think that checking that the linked vmcs is >> not the current vmcs should still be done", I can do that or you can >> send an incremental patch that I'll squash into patch 7. >> >> Thanks, >> >> Paolo > There is also the following comments on "[01/22] KVM: VMX: Create struct > for VMCS header": > 1) Radim prefer to copy-paste an embedded vmcs_hdr struct both for vmcs > and vmcs12 structures. I had missed this, but it can be sorted out separately. > 2) "|| new_vmcs12->hdr.shadow" should be added to the diff in > handle_vmptrld(). This I had fixed myself. Paolo
