On 13/07/2018 19:10, Vitaly Kuznetsov wrote: >> Because bikeshedding is fun, what do you think about using fs_base and >> kernel_gs_base for these names? I have a series that touches this >> code and also adds local variables for {FS,GS}.base and {FS,GS}.sel. >> I used {fs,gs}_base and {fs,gs}_sel to be consistent with the >> vmx->host_state nomenclature (the local variables are used to update >> the associated vmx->host_state variables), but I'll change my patches >> if you have a strong preference for omitting the underscore. >> > I have nothing against underscores :-) > > Hope this small change can be done by Paolo/Radim upon commit. Or I'll > send v2 if needed. Yup, I've made the change and queued for 4.18-rc. Paolo