> -----Original Message----- > From: kvm-owner@xxxxxxxxxxxxxxx [mailto:kvm-owner@xxxxxxxxxxxxxxx] On Behalf Of Alexander Shishkin > Sent: Thursday, July 5, 2018 8:12 PM > To: Kang, Luwei <luwei.kang@xxxxxxxxx>; kvm@xxxxxxxxxxxxxxx > Cc: x86@xxxxxxxxxx; Kang, Luwei <luwei.kang@xxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; Ingo Molnar > <mingo@xxxxxxxxxx>; H. Peter Anvin <hpa@xxxxxxxxx>; Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>; Song Liu > <songliubraving@xxxxxx>; Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Subject: Re: [PATCH v10 05/12] perf/x86/intel/pt: Introduce a new function to get capability of Intel PT > > Luwei Kang <luwei.kang@xxxxxxxxx> writes: > > > New function pt_cap_decode() will be invoked in KVM to check if a > > specific capability is available in KVM guest. > > Another function pt_cap_get() can only check the hardware capabilities > > but this may different with KVM guest because some features may not be > > exposed to guest. > > I would word it more like this: > > "This patch adds a function to query PT capabilities from a cached PT CPUID leaf. This is useful for KVM that maintains its own > modified copy of this leaf, that only contains capabilities that it wants to expose to the guest." > > Also, is there any reason why this and 02/12 are separate patches? Sorry for delay reply. This patch with 02/12 is one patch first, but be separated to two patches later because they are two different things. One is just moving and this patch is adding new capability. Thanks, Luwei Kang
