On 27/06/18 14:59, Suzuki K Poulose wrote: > Marc, > > On 27/06/18 13:20, Marc Zyngier wrote: >> The arm and arm64 KVM page tables accessors are pointlessly different >> between the two architectures, and likely both wrong one way or another: >> arm64 lacks a dsb(), and arm doesn't use WRITE_ONCE. >> >> Let's unify them. > > nit: Feel free to ignore. The changes introducing kvm_p.d_populate > is not mentioned in the commit description and they do look a bit > disconnected from the change described above. That's a good point. I've moved those into patch #5, where they make much more sense. Thanks, M. -- Jazz is not dead. It just smells funny...