On 27/06/2018 10:02, Thomas Huth wrote: > These patches make more x86 kvm-unit-test files compilable with > -Wmissing-prototypes and -Wstrict-prototypes. These two warning > options can help to make sure that function parameters really > always match the function definition, so I think it's a good idea > to finally have this in kvm-unit-tests, too. > > Note that the two compiler flags aren't turned on yet, since I haven't > fixed all x86-related files yet (and the patches here are already big > enough, so I didn't want to increase this patch series further), and > the ARM-related patch hasn't been merged yet (see Andrew's patch here: > https://www.spinics.net/lists/kvm/msg170095.html). > > Thomas Huth (4): > Make vmx_tests.c compilable with -Wmissing-prototypes and > -Wstrict-prototypes > Make realmode.c compilable with -Wmissing-prototypes and > -Wstrict-prototypes > Make remaining x86 code compilable with -Wstrict-prototypes > Mark many test functions as static > > lib/x86/processor.h | 2 +- > lib/x86/smp.c | 2 +- > lib/x86/vm.h | 2 +- > x86/access.c | 45 ++++++++-------- > x86/apic.c | 10 ++-- > x86/emulator.c | 32 ++++++------ > x86/eventinj.c | 4 +- > x86/hyperv_clock.c | 2 +- > x86/idt_test.c | 4 +- > x86/kvmclock.c | 2 +- > x86/kvmclock.h | 2 +- > x86/pcid.c | 16 +++--- > x86/pku.c | 2 +- > x86/pmu.c | 2 +- > x86/port80.c | 2 +- > x86/realmode.c | 67 ++++++++++++------------ > x86/s3.c | 2 +- > x86/setjmp.c | 2 +- > x86/sieve.c | 6 +-- > x86/smptest.c | 2 +- > x86/svm.c | 4 +- > x86/syscall.c | 6 +-- > x86/tsc.c | 10 ++-- > x86/tsc_adjust.c | 2 +- > x86/vmexit.c | 2 +- > x86/vmx.c | 8 +-- > x86/vmx.h | 6 +-- > x86/vmx_tests.c | 146 ++++++++++++++++++++++++++-------------------------- > x86/xsave.c | 14 ++--- > 29 files changed, 204 insertions(+), 202 deletions(-) > Queued, thanks. Paolo