Re: [PATCH 2/2] KVM: arm64: Prevent KVM_COMPAT from being selected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 19, 2018 at 10:42:51AM +0100, Marc Zyngier wrote:
> There is very little point in trying to support the 32bit KVM/arm API
> on arm64, and this was never an anticipated use case.
> 
> Let's make it clear by not selecting KVM_COMPAT.

Do any other architectures have KVM && COMPAT, and expose an
incompatible ABI to COMPAT tasks?

> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>

Given the state of arm/arm64, this makes sense to me. FWIW:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

> ---
>  virt/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig
> index 72143cfaf6ec..ea434ddc8499 100644
> --- a/virt/kvm/Kconfig
> +++ b/virt/kvm/Kconfig
> @@ -47,7 +47,7 @@ config KVM_GENERIC_DIRTYLOG_READ_PROTECT
>  
>  config KVM_COMPAT
>         def_bool y
> -       depends on KVM && COMPAT && !S390
> +       depends on KVM && COMPAT && !(S390 || ARM64)
>  
>  config HAVE_KVM_IRQ_BYPASS
>         bool
> -- 
> 2.17.1
> 



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux