On 12/06/18 14:40, Will Deacon wrote: > Hi Jean-Philippe, > > Sorry it took so long to look at this. > > On Thu, Mar 15, 2018 at 03:04:51PM +0000, Jean-Philippe Brucker wrote: >> Add vfio-pci support to kvmtool. Devices are assigned to the guest by >> passing "--vfio-pci [domain:]bus:dev.fn" to lkvm run, after having bound >> the device to the VFIO driver (see Documentation/vfio.txt) >> >> This version addresses Punit's comments on v4. Patch 7/13 is new; 8/13 >> and 9/13 have fixes. You can find the full diff v4..v5 at the end of >> this cover letter. >> >> I'm testing the series on arm64 and x86, by passing an Intel x540 NIC to >> a guest on AMD Seattle, and an e1000e NIC on QEMU q35. > > Mostly looks good to me, but I have a few small comments on a few of the > patches. Once we've addressed those, I'll apply the series. Thanks! I'll resend the series after a few tests Jean