On 12/06/18 14:40, Will Deacon wrote: >> +enum kvm_mem_type { >> + KVM_MEM_TYPE_RAM = 1 << 1, >> + KVM_MEM_TYPE_DEVICE = 1 << 2, > > Just curious, but is there a reason not to start this from '1 << 0'? Patch 12 uses 1 << 0 for TYPE_RESERVED, though I don't have a good reason for that order. Thanks, Jean