Re: [PATCH v2 03/17] kvm: x86: Add fast CR3 switch code path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/13/2018 09:32 AM, Sean Christopherson wrote:
>> +
>> +			vcpu->arch.cr3 = new_cr3;
>> +			__set_bit(VCPU_EXREG_CR3,
>> +				  (ulong *)&vcpu->arch.regs_avail);
> Setting arch.cr3 here is unnecessary, kvm_set_cr3() is handling that
> duty before and after this patch.  It's also confusing because the
> code in question is later removed in PATCH 06/17, which makes it seem
> like that patch is introducing a bug.
> 

Yes, you are right. I'll remove it from here.

Thanks,
Junaid



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux