Provide prototypes where needed and avoid prototypes that do not specify the function parameters. Reviewed-by: David Hildenbrand <david@xxxxxxxxxx> Signed-off-by: Thomas Huth <thuth@xxxxxxxxxx> --- lib/s390x/io.c | 6 ++++-- s390x/gs.c | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/s390x/io.c b/lib/s390x/io.c index eb4d171..17d5fc7 100644 --- a/lib/s390x/io.c +++ b/lib/s390x/io.c @@ -21,6 +21,8 @@ uint8_t stfl_bytes[NR_STFL_BYTES] __attribute__((aligned(8))); static struct spinlock lock; +void setup(void); + void puts(const char *s) { spin_lock(&lock); @@ -28,7 +30,7 @@ void puts(const char *s) spin_unlock(&lock); } -static void sigp_stop() +static void sigp_stop(void) { register unsigned long status asm ("1") = 0; register unsigned long cpu asm ("2") = 0; @@ -38,7 +40,7 @@ static void sigp_stop() : "+d" (status) : "d" (cpu), "d" (5) : "cc"); } -void setup() +void setup(void) { setup_args_progname(ipl_args); setup_facilities(); diff --git a/s390x/gs.c b/s390x/gs.c index b9b19dd..0cba5dd 100644 --- a/s390x/gs.c +++ b/s390x/gs.c @@ -64,6 +64,8 @@ static struct gs_cb gs_cb; static struct gs_epl gs_epl; static unsigned long gs_area = 0x2000000; +void gs_handler(struct gs_cb *this_cb); + static inline void load_gs_cb(struct gs_cb *gs_cb) { asm volatile(".insn rxy,0xe3000000004d,0,%0" : : "Q" (*gs_cb)); -- 1.8.3.1