On Tue, Jun 12, 2018 at 08:52:08PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 8:26 PM Linus Torvalds > <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > Ok, so commit 95cde3c59966 ("debugfs: inode: debugfs_create_dir uses > > mode permission from parent") breaks lkvm, and I think qemu-kvm too. > > > > The commit looks like the RightThing(tm) to do, but we do not break > > existing work-flows, no matter how much we'd like to. So it gets > > reverted. > > I suspect it's the special kvm debugfs entries - see kvm_create_vm_debugfs() > > Anyway, I've verified that both qemu-kvm and kvm-tool work fine with > the revert in place. I should have read the whole thread :) The revert is fine, I'll work on the kvm debugfs file stuff for 4.19. thanks, greg k-h