> -----Original Message----- > From: kvm-owner@xxxxxxxxxxxxxxx [mailto:kvm-owner@xxxxxxxxxxxxxxx] > On Behalf Of Eduardo Habkost > Sent: Monday, June 11, 2018 4:05 PM > To: Moger, Babu <Babu.Moger@xxxxxxx> > Cc: mst@xxxxxxxxxx; marcel.apfelbaum@xxxxxxxxx; pbonzini@xxxxxxxxxx; > rth@xxxxxxxxxxx; mtosatti@xxxxxxxxxx; qemu-devel@xxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; kash@xxxxxxxxxxxxxx; geoff@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v13 2/5] i386: Introduce auto_topoext bit to manage > topoext > > On Mon, Jun 11, 2018 at 05:46:23PM -0300, Eduardo Habkost wrote: > [...] > > On PC_COMPAT_2_12, both would work: > > { TYPE_X86_CPU, "auto-topoext", "off" } > > or > > { "EPYC" "-" TYPE_X86_CPU, "auto-topoext", "off" }. > > > > I prefer the latter, but both would work. > > Oh, while we're at it: please name the property "x-auto-topoext", > to indicate it's only for QEMU internal use or debugging, and not > a supported command-line option. Ok. Sure. > > -- > Eduardo
