On Thu, Jun 07, 2018 at 11:58:05AM +0300, Timofey Titovets wrote: > вт, 29 мая 2018 г. в 17:46, Pavel Tatashin <pasha.tatashin@xxxxxxxxxx>: > > > > > What about moving choice_fastest_hash() to run_store()? > > > > > KSM anyway starts with ksm_run = KSM_RUN_STOP and does not scan until > > > userspace writes !0 to /sys/kernel/mm/ksm/run. > > > > > Selection of the hash function when KSM is actually enabled seems quite > > > appropriate... > > > > Hi Mike, > > > > This is a good idea to select hash function from run_store() when (flags & > > KSM_RUN_MERGE) is set for the first time. > > > > Pavel > > IIRC, run_store hidden under '#ifdef CONFIG_SYSFS' > So, what's about case without CONFIG_SYSFS? With CONFIG_SYSFS=n there is nothing that will set ksm_run to anything but zero and ksm_do_scan will never be called. > -- > Have a nice day, > Timofey. > -- Sincerely yours, Mike.
