> -----Original Message----- > From: Kash Pande [mailto:kash@xxxxxxxxxxxxxx] > Sent: Thursday, May 24, 2018 10:51 AM > To: Moger, Babu <Babu.Moger@xxxxxxx>; mst@xxxxxxxxxx; > marcel.apfelbaum@xxxxxxxxx; pbonzini@xxxxxxxxxx; rth@xxxxxxxxxxx; > ehabkost@xxxxxxxxxx; mtosatti@xxxxxxxxxx > Cc: qemu-devel@xxxxxxxxxx; kvm@xxxxxxxxxxxxxxx; geoff@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v11 0/5] i386: Enable TOPOEXT to support > hyperthreading on AMD CPU > > Tested-by: Kash Pande <kash@xxxxxxxxxxxxxx> Thanks > > > Hopefully we can get this merged because it's taken a ridiculously long > time with many back-and-forths for small issues that could have been put > off til later. We are almost there. Thanks for your patience. ): > > Kash > > On 2018-05-24 11:43 AM, Babu Moger wrote: > > This series enables the TOPOEXT feature for AMD CPUs. This is required to > > support hyperthreading on kvm guests. > > > > This addresses the issues reported in these bugs: > > https://bugzilla.redhat.com/show_bug.cgi?id=1481253 > > https://bugs.launchpad.net/qemu/+bug/1703506 > > > > v11: > > Patches are based off of Eduardo's git://github.com/ehabkost/qemu.git > x86-next. > > Summary of changes. > > 1.Added more comments explaining different constants and variables. > > 2.Removed NUM_SHARING_CACHE macro and made the code simpler. > > 3.Changed the function name num_sharing_l3_cache to > cores_in_core_complex. > > This function is actually finding the number of cores in a core complex. > > Purpose here is to re-use the code in couple more places. > > 4.Added new function nodes_in_socket to find number of nodes in the > config. > > Purpose here is to re-use the code. > > 5.Used DIV_ROUND_UP wherever applicable. > > 6.Renamed few constants and functions to generic names. > > 7.Few more text corrections. > > >
