On Tue, May 22, 2018 at 10:01 AM, Liran Alon <liran.alon@xxxxxxxxxx> wrote: > > ----- jmattson@xxxxxxxxxx wrote: > >> On Tue, May 22, 2018 at 7:16 AM, Liran Alon <liran.alon@xxxxxxxxxx> >> wrote: >> >> > + /* >> > + * If vmcs01 don't use VPID, CPU flushes TLB on every >> > + * VMEntry/VMExit. Thus, no need to flush TLB. >> > + * >> > + * If vmcs12 uses VPID, TLB entries populated by L2 are >> > + * tagged with vmx->nested.vpid02 while L1 entries are >> tagged >> > + * with vmx->vpid. Thus, no need to flush TLB. >> > + * >> >> Furthermore, If vmcs12 uses EPT, TLB entries populated by L2 are >> tagged with the vmcs02 EP4TA while L1 entries are tagged with the >> vmcs01 EP4TA. Thus, no need to flush the TLB. > > I agree. But let's do that as a separate patch on top of this patch. > To make each patch more readable and handle one issue at a time. In that case... Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>
