1. Inside parentheses there is no need to fix anything. e.g. the following code is fine:
logging.info("Copying %s.tar.bz2 to guest (file is missing or has a"
" different size)..." % test_name)
and also looks cleaner than the new version with the backslash and weird indentation.
(I think it looks cleaner to have the space on the first line, i.e.
logging.info("Copying %s.tar.bz2 to guest (file is missing or has a "
"different size)..." % test_name)
but that is just being petty.)
2. Outside parentheses, I think it's cleaner to use a backslash outside the quotes, and proper indentation, e.g.
instead of:
message_fail = "Test '%s' did not produce any recognizable \
results" % test_name
consider:
message_fail = "Test '%s' did not produce any recognizable " \
"results" % test_name
or with 8 spaces -- I'm not sure what's better:
message_fail = "Test '%s' did not produce any recognizable " \
"results" % test_name
I think it's a good idea to use proper indentation also where no strings are involved --
instead of:
stat_str = 'From %d tests executed, %d have passed (%d%% failures)' % \
(total_executed, total_passed, failed_perct)
consider:
stat_str = 'From %d tests executed, %d have passed (%d%% failures)' % \
(total_executed, total_passed, failed_perct)
^
|
vim auto-indents by 8 spaces here, but I'm not sure what the convention is. I'm pretty sure indentation is a good idea though.
Again, I'm sorry if I'm being petty. If I made a mistake understanding your patch or the conventions, please correct me.
Thanks,
Michael
----- Original Message -----
From: "Lucas Meneghel Rodrigues" <lmr@xxxxxxxxxx>
To: autotest@xxxxxxxxxxxxxxx
Cc: kvm@xxxxxxxxxxxxxxx
Sent: Monday, June 8, 2009 7:04:29 AM (GMT+0200) Auto-Detected
Subject: [Autotest] [PATCH 2/3] Fixing bad line breaks
During the conversion of logging statements, some bad line
continuation were introduced. This patch fixes the mistakes.
Signed-off-by: Lucas Meneghel Rodrigues <lmr@xxxxxxxxxx>
---
client/tests/kvm/kvm_tests.py | 12 ++++++------
client/tests/kvm/make_html_report.py | 5 ++---
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/client/tests/kvm/kvm_tests.py b/client/tests/kvm/kvm_tests.py
index cccc48e..9adea6f 100644
--- a/client/tests/kvm/kvm_tests.py
+++ b/client/tests/kvm/kvm_tests.py
@@ -274,8 +274,8 @@ def run_autotest(test, params, env):
copy = True
# Perform the copy
if copy:
- logging.info("Copying %s.tar.bz2 to guest (file is missing or has a"
- " different size)..." % test_name)
+ logging.info("Copying %s.tar.bz2 to guest \
+ (file is missing or has a different size)..." % test_name)
if not vm.scp_to_remote(tarred_test_path, ""):
raise error.TestFail("Could not copy %s.tar.bz2 to guest" %
test_name)
@@ -291,8 +291,8 @@ def run_autotest(test, params, env):
# Extract <test_name>.tar.bz2 into autotest/tests
logging.info("Extracting %s.tar.bz2..." % test_name)
- status = session.get_command_status("tar xvfj %s.tar.bz2 -C "
- "autotest/tests" % test_name)
+ status = session.get_command_status("tar xvfj %s.tar.bz2 -C \
+ autotest/tests" % test_name)
if status != 0:
raise error.TestFail("Could not extract %s.tar.bz2" % test_name)
@@ -321,8 +321,8 @@ def run_autotest(test, params, env):
status_fail = False
if result_list == []:
status_fail = True
- message_fail = "Test '%s' did not produce any recognizable"
- " results" % test_name
+ message_fail = "Test '%s' did not produce any recognizable \
+ results" % test_name
for result in result_list:
logging.info(str(result))
if result[1] == "FAIL":
diff --git a/client/tests/kvm/make_html_report.py b/client/tests/kvm/make_html_report.py
index 6aed39e..5b2e579 100755
--- a/client/tests/kvm/make_html_report.py
+++ b/client/tests/kvm/make_html_report.py
@@ -1442,9 +1442,8 @@ return true;
stat_str = 'No test cases executed'
if total_executed>0:
failed_perct = int(float(total_failed)/float(total_executed)*100)
- stat_str = 'From %d tests executed, '
- '%d have passed (%d%s)' % (total_executed, total_passed,failed_perct,
- '% failures')
+ stat_str = 'From %d tests executed, %d have passed (%d%% failures)' % \
+ (total_executed, total_passed, failed_perct)
kvm_ver_str = metadata['kvmver']
--
1.6.2.2
_______________________________________________
Autotest mailing list
Autotest@xxxxxxxxxxxxxxx
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
