On Mon, May 07, 2018 at 02:20:06PM +0800, wei.guo.simon@xxxxxxxxx wrote: > From: Simon Guo <wei.guo.simon@xxxxxxxxx> > > We already have analyse_instr() which analyzes instructions for the instruction > type, size, addtional flags, etc. What kvmppc_emulate_loadstore() did is somehow > duplicated and it will be good to utilize analyse_instr() to reimplement the > code. The advantage is that the code logic will be shared and more clean to be > maintained. > > This patch series reimplement kvmppc_emulate_loadstore() for various load/store > instructions. > > The testcase locates at: > https://github.com/justdoitqd/publicFiles/blob/master/test_mmio.c > > - Tested at both PR/HV KVM. > - Also tested with little endian host & big endian guest. This series looks good. I have just a couple of comments on two of the patches. Thanks, Paul.
