Re: [kvm PATCH v2 1/1] kvm: Make VM ioctl do a vzalloc instead of a kzalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 04, 2018 at 11:11:21AM +0200, Christian Borntraeger wrote:
> you should also add the arm/mips/power maintainers so that they can review their
> struct kvm_arch if any of the content is passed directly to the hardware (e.g. with
> __pa). A quick looks seems to indicate that there is no issue.

MIPS has additional restrictions because it has a software managed TLB,
so we have to be careful where we access vmalloc'd memory, especially
around entry point code which may not expect to receive a TLB refill
exception. I'll have a deeper look later to see if it would obviously
break anything.

Thanks
James

> 
> On 05/03/2018 07:59 PM, Marc Orr wrote:
> > The kvm struct is (currently) tens of kilo-bytes, which turns out to be a
> > large amount of memory to allocate contiguously via kzalloc. Thus, this
> > patch changes the kzalloc to a vzalloc, so that the memory allocation is
> > less likely to fail in resource-constrained environments.
> > 
> > Signed-off-by: Marc Orr <marcorr@xxxxxxxxxx>




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux