On Thu, May 03, 2018 at 04:26:12PM +1000, Paul Mackerras wrote: > On Wed, Apr 25, 2018 at 07:54:44PM +0800, wei.guo.simon@xxxxxxxxx wrote: > > From: Simon Guo <wei.guo.simon@xxxxxxxxx> > > > > This patch reconstructs LOAD_VSX/STORE_VSX instruction MMIO emulation with > > analyse_intr() input. It utilizes VSX_FPCONV/VSX_SPLAT/SIGNEXT exported > > by analyse_instr() and handle accordingly. > > > > When emulating VSX store, the VSX reg will need to be flushed so that > > the right reg val can be retrieved before writing to IO MEM. > > > > Suggested-by: Paul Mackerras <paulus@xxxxxxxxxx> > > Signed-off-by: Simon Guo <wei.guo.simon@xxxxxxxxx> > > Looks good, except that you shouldn't need the special case for > stxsiwx. With size=4 and element_size=8, kvmppc_handle_vsx_store > should just do the right thing, as far as I can see. Yes. Let me test after update. Thanks, - Simon
