On Thu, May 03, 2018 at 03:34:01PM +1000, Paul Mackerras wrote: > On Wed, Apr 25, 2018 at 07:54:34PM +0800, wei.guo.simon@xxxxxxxxx wrote: > > From: Simon Guo <wei.guo.simon@xxxxxxxxx> > > > > Current regs are scattered at kvm_vcpu_arch structure and it will > > be more neat to organize them into pt_regs structure. > > > > Also it will enable reconstruct MMIO emulation code with > > "reimplement" would be clearer than "reconstruct" here, I think. > ok. > > @@ -438,7 +438,7 @@ int main(void) > > OFFSET(VCPU_TAR, kvm_vcpu, arch.tar); > > #endif > > OFFSET(VCPU_CR, kvm_vcpu, arch.cr); > > - OFFSET(VCPU_PC, kvm_vcpu, arch.pc); > > + OFFSET(VCPU_PC, kvm_vcpu, arch.nip); > > This hunk shouldn't be in this patch. Yes. sorry my patch split has some issue in patch 00/01. > > Paul. Thanks, - Simon