On Wed, Apr 25, 2018 at 07:54:42PM +0800, wei.guo.simon@xxxxxxxxx wrote: > From: Simon Guo <wei.guo.simon@xxxxxxxxx> > > This patch reconstructs LOAD_FP/STORE_FP instruction MMIO emulation with > analyse_intr() input. It utilizes the FPCONV/UPDATE properties exported by > analyse_instr() and invokes kvmppc_handle_load(s)/kvmppc_handle_store() > accordingly. > > The FP regs need to be flushed so that the right FP reg vals can be read > from vcpu->arch.fpr. This only applies for store instructions; it would be clearer if you said that explicitly. > > Suggested-by: Paul Mackerras <paulus@xxxxxxxxxx> > Signed-off-by: Simon Guo <wei.guo.simon@xxxxxxxxx> Same comment about updating RA as for the other patches. Otherwise this looks fine. Paul.
