Re: [PATCH] migration: fix saving normal page even if it's been compressed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 05/02/2018 10:46 AM, Peter Xu wrote:
On Sat, Apr 28, 2018 at 04:10:45PM +0800, guangrong.xiao@xxxxxxxxx wrote:
From: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxx>

Fix the bug introduced by da3f56cb2e767016 (migration: remove
ram_save_compressed_page()), It should be 'return' rather than
'res'

Sorry for this stupid mistake :(

Signed-off-by: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxx>

Reviewed-by: Peter Xu <peterx@xxxxxxxxxx>

So is that only a performance degradation without this fix (since
AFAIU the compressing pages will be sent twice)?  Thanks,

Yes, that's why we did not detect it in our test. :(



[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux