On 05/02/2018 01:08 PM, David Hildenbrand wrote:
> By missing an "L", we might detect some addresses to be <8k,
> although they are not.
>
> e.g. for itdba = 100001fff
> !(gpa & ~0x1fffU) -> 1
> !(gpa & ~0x1fffUL) -> 0
>
> So we would report a SIE validity intercept although everything is fine.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
Should be cc stable as is might break vsie if for some reason the block is
aligned by 4G.
Reviewed-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> ---
> arch/s390/kvm/vsie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kvm/vsie.c b/arch/s390/kvm/vsie.c
> index 8961e3970901..969882b54266 100644
> --- a/arch/s390/kvm/vsie.c
> +++ b/arch/s390/kvm/vsie.c
> @@ -578,7 +578,7 @@ static int pin_blocks(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
>
> gpa = READ_ONCE(scb_o->itdba) & ~0xffUL;
> if (gpa && (scb_s->ecb & ECB_TE)) {
> - if (!(gpa & ~0x1fffU)) {
> + if (!(gpa & ~0x1fffUL)) {
> rc = set_validity_icpt(scb_s, 0x0080U);
> goto unpin;
> }
>
