Re: [PATCH v1 2/3] KVM: s390: no need to inititalize kvm->arch members to 0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/27/2018 08:36 AM, David Hildenbrand wrote:
> KVM is allocated with kzalloc(), so these members are already 0.
> 
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>

Reviewed-by: Collin Walling <walling@xxxxxxxxxxxxx>

> ---
>  arch/s390/kvm/kvm-s390.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
> index 6efe2b0ba5e1..b3eee3cc6e78 100644
> --- a/arch/s390/kvm/kvm-s390.c
> +++ b/arch/s390/kvm/kvm-s390.c
> @@ -1982,10 +1982,10 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>  
>  	rc = -ENOMEM;
>  
> -	kvm->arch.use_esca = 0; /* start with basic SCA */
>  	if (!sclp.has_64bscao)
>  		alloc_flags |= GFP_DMA;
>  	rwlock_init(&kvm->arch.sca_lock);
> +	/* start with basic SCA */
>  	kvm->arch.sca = (struct bsca_block *) get_zeroed_page(alloc_flags);
>  	if (!kvm->arch.sca)
>  		goto out_err;
> @@ -2036,8 +2036,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>  	kvm_s390_crypto_init(kvm);
>  
>  	mutex_init(&kvm->arch.float_int.ais_lock);
> -	kvm->arch.float_int.simm = 0;
> -	kvm->arch.float_int.nimm = 0;
>  	spin_lock_init(&kvm->arch.float_int.lock);
>  	for (i = 0; i < FIRQ_LIST_COUNT; i++)
>  		INIT_LIST_HEAD(&kvm->arch.float_int.lists[i]);
> @@ -2063,11 +2061,7 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
>  		kvm->arch.gmap->pfault_enabled = 0;
>  	}
>  
> -	kvm->arch.css_support = 0;
> -	kvm->arch.use_irqchip = 0;
>  	kvm->arch.use_pfmfi = sclp.has_pfmfi;
> -	kvm->arch.epoch = 0;
> -
>  	spin_lock_init(&kvm->arch.start_stop_lock);
>  	kvm_s390_vsie_init(kvm);
>  	kvm_s390_gisa_init(kvm);
> 


-- 
Respectfully,
- Collin Walling




[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux