On Thu, Apr 26, 2018 at 12:18 PM, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote: > On Thu, Apr 26, 2018 at 12:10:14PM -0700, Jim Mattson wrote: >> As the comment says above the vmcs12 structure definition, "if there >> are changes in this struct, VMCS12_REVISION must be changed." >> >> Actually, VMCS12_REVISION should never be changed, because such a >> change introduces an incompatibility for live migration across kvm >> versions. > > Would it make sense to have this patch also remove that comment then? Indeed. It looks like more fields have been added, so there will be a v2.