On Fri, Apr 20, 2018 at 12:06:30AM +0000, Peter Shier wrote:
> Thanks very much for the quick review. I indeed had a bug there losing the
> check for unset ERRATA_$commit.
> We do require Bash 4.1 and later compatibility. I would like to change the
> test -v lines to use indirection:
>
> [[ -n "${!errata}" ]] && continue
>
> I tested this on 4.1 and on 4.4. It treats unset and "" as the same which
> should be sufficient here AFAICT (while maintaining compatibility).
> I have a new patch ready to go. Please let me know if this works for you.
>
Yeah, that's fine. One other comment on your patch though is that you
were only changing the 'test -v' in env_generate_errata(). There's
another one in env_add_errata() that should also be changed.
If you can do exhaustive testing or some analysis of the bash code to
ensure it's 4.1 compatible, then we can now document that requirement
in the README as well. I wouldn't want to document it until we're
sure though.
Thanks,
drew
